sashidhar commented on issue #7833: Make StatusResponseHandler singleton URL: https://github.com/apache/incubator-druid/issues/7833#issuecomment-505899895 @leventov, 1. I see instantiations using default charset in tests - JettyTest.java and JettyQosTest. `new StatusResponseHandler(Charset.defaultCharset())` Can they be safely changed to use UTF_8 ? 2. What singleton pattern do you suggest ? Early instantiation using a static member or a lazy instantiation using a double locking mechanism.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
