clintropolis commented on a change in pull request #8068: Druid SQL EXTRACT
time function - adding support for additional Time Units
URL: https://github.com/apache/incubator-druid/pull/8068#discussion_r302850583
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/http/SqlResourceTest.java
##########
@@ -689,6 +689,18 @@ private void checkSqlRequestLog(boolean success)
}
}
+ @Test
+ public void testExtractMillisecondFromExpr() throws Exception
Review comment:
I think `CalciteQueryTests` might be a more appropriate place to test this,
maybe have a look at `CalciteQueryTest.testFilterOnTimeExtract`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
