clintropolis commented on a change in pull request #8068: Druid SQL EXTRACT
time function - adding support for additional Time Units
URL: https://github.com/apache/incubator-druid/pull/8068#discussion_r303225169
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/http/SqlResourceTest.java
##########
@@ -689,6 +689,18 @@ private void checkSqlRequestLog(boolean success)
}
}
+ @Test
+ public void testExtractMillisecondFromExpr() throws Exception
Review comment:
Overall seems reasonable to me :+1:. You could probably test most/all of the
additions in a single test if the timestamps for the datasource you added are
sufficient, if you'd like to avoid repeating a lot of the near same boilerplate
in the calcite tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
