leventov commented on a change in pull request #7562: Enable ability to toggle
SegmentMetadata request logging on/off
URL: https://github.com/apache/incubator-druid/pull/7562#discussion_r303087201
##########
File path:
server/src/main/java/org/apache/druid/server/log/FilteredRequestLoggerProvider.java
##########
@@ -63,12 +68,15 @@ public RequestLogger get()
private final RequestLogger logger;
private final long queryTimeThresholdMs;
private final long sqlQueryTimeThresholdMs;
+ private final boolean logSegmentMetadataQueries;
- public FilteredRequestLogger(RequestLogger logger, long
queryTimeThresholdMs, long sqlQueryTimeThresholdMs)
+ public FilteredRequestLogger(RequestLogger logger, long
queryTimeThresholdMs, long sqlQueryTimeThresholdMs,
Review comment:
According to Druid style, should chop down the list of params:
```suggestion
public FilteredRequestLogger(
RequestLogger logger,
long queryTimeThresholdMs,
long sqlQueryTimeThresholdMs,
boolean logSegmentMetadataQueries
)
{
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
