leventov opened a new issue #4113: Refactor QueryRunner.run(), make responseContext immutable URL: https://github.com/apache/incubator-druid/issues/4113 Mutable Map, passed into QueryRunner.run(), is abused: https://github.com/druid-io/druid/issues/4112 and inherently broken with async/concurrent runners: https://github.com/druid-io/druid/issues/3803. I suggest to change QueryRunner signature to ```java QueryResult<T> run(Query<T> query); ``` where ```java class QueryResult<T> { final Sequence<T> result; final ImmutableMap<String, Object> responseContext; } ``` What do you think? @himanshug @gianm
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
