clintropolis commented on a change in pull request #8116: remove unnecessary
lock in ForegroundCachePopulator leading to a lot of contention
URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305609525
##########
File path:
server/src/main/java/org/apache/druid/client/cache/ForegroundCachePopulator.java
##########
@@ -36,7 +36,6 @@
{
Review comment:
I think there isn't so much concurrent access to document anymore since all
concurrency primitives have been removed from `ForegroundCachePopulator`, which
I think previously qualified for the [excessive thread
safety](https://github.com/code-review-checklists/java-concurrency#excessive-thread-safety)
section. I have tried to update the javadocs of `CachePopulator` to describe
it's usage and how the sequence is consumed, so hopefully at least I've left it
better than I found it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
