jon-wei commented on a change in pull request #8107: Add CliIndexer process
type and initial task runner implementation
URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088362
##########
File path:
server/src/main/java/org/apache/druid/server/initialization/jetty/ChatHandlerServerModule.java
##########
@@ -67,11 +69,21 @@ public void configure(Binder binder)
Multibinder.newSetBinder(binder,
ServletFilterHolder.class).addBinding().to(TaskIdResponseHeaderFilterHolder.class);
- /**
- * We bind {@link DruidNode} annotated with {@link RemoteChatHandler} to
{@literal @}{@link Self} {@link DruidNode}
- * so that same Jetty Server is used for querying as well as ingestion.
- */
-
binder.bind(DruidNode.class).annotatedWith(RemoteChatHandler.class).to(Key.get(DruidNode.class,
Self.class));
+ if (useSeparatePort) {
+ // bind a modified DruidNode that will be used by the Jetty server
installed below
+ binder.bind(DruidNode.class)
Review comment:
I redid this to use QoS filters, the configured number of connections are
doubled (one set for chat handler, the other for non-chat handler requests),
with 2 reserved connections for lookups
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
