jon-wei commented on a change in pull request #8107: Add CliIndexer process
type and initial task runner implementation
URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306089074
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
##########
@@ -386,12 +392,14 @@ public TaskStatus run(final TaskToolbox toolbox)
toolbox.getMonitorScheduler().removeMonitor(metricsMonitor);
- toolbox.getDataSegmentServerAnnouncer().unannounce();
- toolbox.getDruidNodeAnnouncer().unannounce(discoveryDruidNode);
+ if (appenderatorsManager.shouldTaskMakeNodeAnnouncements()) {
Review comment:
I had done that initially, but decided to just use a boolean since the
CliIndexer implementation would've done nothing for those methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
