jihoonson opened a new pull request #8141: Use PartitionsSpec for all task types URL: https://github.com/apache/incubator-druid/pull/8141 Part of https://github.com/apache/incubator-druid/issues/8061. ### Description `PartitionsSpec` is a class to describe the secondary partitioning method for data ingestion, but is being used by only Hadoop tasks. For more consistent behavior and configuration, all task types should use the same `PartitionsSpec`. `PartitionsSpec` is the top interface and has one direct implementation, `DynamicPartitionsSpec`. `DynamicPartitionsSpec` is the new partitionsSpec and used by indexTask and kafka/kinesis IndexTasks. `DimensionBasedPartitionsSpec` is the child interface of `PartitionsSpec` and represents the partitionsSpec based on dimension values. It has two implementations of `HashedPartitionsSpec` and `SingleDimensionPartitionsSpec`. These partitionsSpecs are used if and only if perfect rollup is configured. This PR is _backward-Incompatible_ for indexTask because the JSON form of tuningConfig doesn't have `maxRowsPerSegment`, `maxTotalRows`, `numShards`, and `partitionDimensions` anymore. However, it still could read the old JSON format. It should be compatible for other task types. <hr> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
