Fokko commented on a change in pull request #8129: Spotbugs:
NP_NONNULL_PARAM_VIOLATION
URL: https://github.com/apache/incubator-druid/pull/8129#discussion_r308915853
##########
File path:
extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogram.java
##########
@@ -532,9 +534,9 @@ public ApproximateHistogram copy(ApproximateHistogram h)
//approximate histogram solution using min heap to store location of min
deltas
protected ApproximateHistogram foldMin(
ApproximateHistogram h,
- float[] mergedPositions,
- long[] mergedBins,
- float[] deltas
+ @Nullable float[] mergedPositions,
Review comment:
We can drop zero-sized arrays instead and drop in the `@Visible for
testing`. Which is nicer in my opinion. Would love to get your opinion on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
