Fokko commented on a change in pull request #8129: Spotbugs:
NP_NONNULL_PARAM_VIOLATION
URL: https://github.com/apache/incubator-druid/pull/8129#discussion_r308916996
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
##########
@@ -377,7 +377,7 @@ public Row apply(final Row row)
);
}
catch (Exception ex) {
- Lists.reverse(closeOnExit).forEach(closeable ->
CloseQuietly.close(closeable));
+ Lists.reverse(closeOnExit).forEach(CloseQuietly::close);
Review comment:
The code did not change, but we're the Java8 reference function notation:
https://www.codementor.io/eh3rrera/using-java-8-method-reference-du10866vx
This will pass the `CloseQuietly::close` as the reference to the method, and
this will be applied to each of the closables.
Please let me know what you think of this notation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
