clintropolis commented on a change in pull request #8047: optimize single input
column multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503545
##########
File path:
processing/src/test/java/org/apache/druid/segment/filter/ExpressionFilterTest.java
##########
@@ -147,6 +147,7 @@ public void testOneMultiValuedStringColumn()
}
assertFilterMatchesSkipVectorize(edf("dim4 == '1'"),
ImmutableList.of("0"));
assertFilterMatchesSkipVectorize(edf("dim4 == '3'"),
ImmutableList.of("3"));
+ assertFilterMatchesSkipVectorize(edf("dim4 == '4'"), ImmutableList.of("4",
"5"));
Review comment:
I .. don't really remember, I'm going to go with the reason was for fun, to
add another test that actually has multiple matches in the case where sql
compatible null handling is enabled 😜
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
