clintropolis commented on a change in pull request #8047: optimize single input
column multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503937
##########
File path:
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java
##########
@@ -230,8 +230,9 @@ public static DimensionSelector makeDimensionSelector(
&& capabilities.getType() == ValueType.STRING
&& capabilities.isDictionaryEncoded()
&& capabilities.isComplete()
- && !capabilities.hasMultipleValues()
- && !exprDetails.getArrayColumns().contains(column)
+ && !exprDetails.hasInputArrays()
+ && !exprDetails.isOutputArray()
+ && (!capabilities.hasMultipleValues() ||
exprDetails.getFreeVariables().size() == 1)
) {
// Optimization for dimension selectors that wrap a single underlying
string column.
Review comment:
The logic is only used in these 2 places in ExpressionSelectors I think, and
it's slightly different between the uses because
`SingleStringInputDimensionSelector` supports multi-value inputs, but
`SingleStringInputCachingExpressionColumnValueSelector` does not. I'll play
around and see what I can do, or at least comment what's going on heavily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
