vogievetsky commented on a change in pull request #8251: Web-Console: Add show
and copy actions to column tree
URL: https://github.com/apache/incubator-druid/pull/8251#discussion_r311315490
##########
File path: web-console/src/views/query-view/column-tree/column-tree.tsx
##########
@@ -16,57 +16,286 @@
* limitations under the License.
*/
-import { HTMLSelect, IconName, ITreeNode, Tree } from '@blueprintjs/core';
+import { HTMLSelect, IconName, Intent, ITreeNode, Tree } from
'@blueprintjs/core';
+import { Popover } from '@blueprintjs/core/lib/cjs';
+import { Position } from '@blueprintjs/core/lib/esm/common/position';
import { IconNames } from '@blueprintjs/icons';
+import copy = require('copy-to-clipboard');
import React, { ChangeEvent } from 'react';
import { Loader } from '../../../components';
+import { AppToaster } from '../../../singletons/toaster';
import { escapeSqlIdentifier, groupBy } from '../../../utils';
+import { basicActionsToMenu } from '../../../utils/basic-action';
import { ColumnMetadata } from '../../../utils/column-metadata';
import './column-tree.scss';
+function handleTableClick(
+ tableSchema: string,
+ nodeData: ITreeNode,
+ onQueryStringChange: (queryString: string) => void,
+): void {
+ let columns: string[];
+ if (nodeData.childNodes) {
+ columns = nodeData.childNodes.map(child =>
escapeSqlIdentifier(String(child.label)));
+ } else {
+ columns = ['*'];
+ }
+ if (tableSchema === 'druid') {
+ onQueryStringChange(`SELECT ${columns.join(', ')}
+FROM ${escapeSqlIdentifier(String(nodeData.label))}
+WHERE "__time" >= CURRENT_TIMESTAMP - INTERVAL '1' DAY`);
+ } else {
+ onQueryStringChange(`SELECT ${columns.join(', ')}
+FROM ${tableSchema}.${nodeData.label}`);
+ }
+}
+
+function getTableQuery(tableSchema: string, nodeData: ITreeNode): string {
+ let columns: string[];
+ if (nodeData.childNodes) {
+ columns = nodeData.childNodes.map(child =>
escapeSqlIdentifier(String(child.label)));
+ } else {
+ columns = ['*'];
+ }
+ if (tableSchema === 'druid') {
+ return `SELECT ${columns.join(', ')}
+FROM ${escapeSqlIdentifier(String(nodeData.label))}
+WHERE "__time" >= CURRENT_TIMESTAMP - INTERVAL '1' DAY`;
+ } else {
+ return `SELECT ${columns.join(', ')}
+FROM ${tableSchema}.${nodeData.label}`;
+ }
+}
+
+function handleColumnClick(
+ columnSchema: string,
+ columnTable: string,
+ nodeData: ITreeNode,
+ onQueryStringChange: (queryString: string) => void,
+): void {
+ if (columnSchema === 'druid') {
+ if (nodeData.icon === IconNames.TIME) {
+ onQueryStringChange(`SELECT
+ TIME_FLOOR(${escapeSqlIdentifier(String(nodeData.label))}, 'PT1H') AS "Time",
+ COUNT(*) AS "Count"
+FROM ${escapeSqlIdentifier(columnTable)}
+WHERE "__time" >= CURRENT_TIMESTAMP - INTERVAL '1' DAY
+GROUP BY 1
+ORDER BY "Time" ASC`);
+ } else {
+ onQueryStringChange(`SELECT
+ "${nodeData.label}",
+ COUNT(*) AS "Count"
+FROM ${escapeSqlIdentifier(columnTable)}
+WHERE "__time" >= CURRENT_TIMESTAMP - INTERVAL '1' DAY
+GROUP BY 1
+ORDER BY "Count" DESC`);
+ }
+ } else {
+ onQueryStringChange(`SELECT
+ ${escapeSqlIdentifier(String(nodeData.label))},
+ COUNT(*) AS "Count"
+FROM ${columnSchema}.${columnTable}
+GROUP BY 1
+ORDER BY "Count" DESC`);
+ }
+}
+
+function getColumnQuery(columnSchema: string, columnTable: string, nodeData:
ITreeNode): string {
+ if (columnSchema === 'druid') {
+ if (nodeData.icon === IconNames.TIME) {
+ return `SELECT
+ TIME_FLOOR(${escapeSqlIdentifier(String(nodeData.label))}, 'PT1H') AS "Time",
+ COUNT(*) AS "Count"
+FROM ${escapeSqlIdentifier(columnTable)}
+WHERE "__time" >= CURRENT_TIMESTAMP - INTERVAL '1' DAY
+GROUP BY 1
+ORDER BY "Time" ASC`;
+ } else {
+ return `SELECT
+ "${nodeData.label}",
+ COUNT(*) AS "Count"
+FROM ${escapeSqlIdentifier(columnTable)}
+WHERE "__time" >= CURRENT_TIMESTAMP - INTERVAL '1' DAY
+GROUP BY 1
+ORDER BY "Count" DESC`;
+ }
+ } else {
+ return `SELECT
+ ${escapeSqlIdentifier(String(nodeData.label))},
+ COUNT(*) AS "Count"
+FROM ${columnSchema}.${columnTable}
+GROUP BY 1
+ORDER BY "Count" DESC`;
+ }
+}
+
export interface ColumnTreeProps {
columnMetadataLoading: boolean;
columnMetadata?: ColumnMetadata[];
onQueryStringChange: (queryString: string) => void;
+ defaultSchema?: string;
+ defaultTable?: string;
}
export interface ColumnTreeState {
prevColumnMetadata?: ColumnMetadata[];
columnTree?: ITreeNode[];
selectedTreeIndex: number;
+ expandedNode: number;
}
export class ColumnTree extends React.PureComponent<ColumnTreeProps,
ColumnTreeState> {
static getDerivedStateFromProps(props: ColumnTreeProps, state:
ColumnTreeState) {
- const { columnMetadata } = props;
+ const { columnMetadata, defaultSchema, defaultTable } = props;
if (columnMetadata && columnMetadata !== state.prevColumnMetadata) {
+ const columnTree = groupBy(
+ columnMetadata,
+ r => r.TABLE_SCHEMA,
+ (metadata, schema): ITreeNode => ({
+ id: schema,
+ label: schema,
+ childNodes: groupBy(
+ metadata,
+ r => r.TABLE_NAME,
+ (metadata, table) => ({
+ id: table,
+ icon: IconNames.TH,
+ label: (
+ <Popover
+ boundary={'window'}
+ position={Position.RIGHT}
+ content={basicActionsToMenu([
Review comment:
No need to use `basicActionsToMenu` I want to get rid of this function
completely, maybe factor out the menus into functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
