vogievetsky commented on a change in pull request #8251: Web-Console: Add show
and copy actions to column tree
URL: https://github.com/apache/incubator-druid/pull/8251#discussion_r311332811
##########
File path: web-console/src/views/query-view/query-view.tsx
##########
@@ -384,11 +411,60 @@ export class QueryView extends
React.PureComponent<QueryViewProps, QueryViewStat
)}
</div>
</div>
- <QueryOutput loading={loading} result={result} error={error} />
+ <QueryOutput
+ aggregateColumns={ast ? ast.getAggregateColumns() : undefined}
+ disabled={!ast}
+ sorted={ast ? ast.getSorted() : undefined}
+ handleSqlAction={this.handleSqlAction}
+ loading={loading}
+ result={result}
+ error={error}
+ />
</SplitterLayout>
);
}
+ private handleSqlAction = (row: string, header: string, action: string):
void => {
Review comment:
maybe worth breaking this one down so there is no switch statement, the way
it is coded now seems like an anti-pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
