leventov commented on a change in pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks URL: https://github.com/apache/incubator-druid/pull/8236#discussion_r312194391
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java ########## @@ -162,15 +162,21 @@ default int getPriority() Review comment: Could you please add an overview section to `Task`'s class-level Javadoc, describing which methods of this interface could be called concurrently with which other methods and which could not? In other words, provide an overview [concurrent access documentation](https://github.com/code-review-checklists/java-concurrency#justify-document) for this interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
