leventov commented on a change in pull request #8236: Add TaskResourceCleaner;
fix a couple of concurrency bugs in batch tasks
URL: https://github.com/apache/incubator-druid/pull/8236#discussion_r312195277
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java
##########
@@ -162,15 +162,21 @@ default int getPriority()
/**
* Asks a task to arrange for its "run" method to exit promptly. Tasks that
take too long to stop gracefully will be
- * terminated with extreme prejudice. Note that this method can be called at
any time while {@link #run} is called.
- * Its implementations should handle potential concurreny issues properly.
+ * terminated with extreme prejudice.
+ *
+ * This method can be called at any time while {@link #run} is being called
when the task is killed.
Review comment:
Could you specify what should or should not happen if `stopGracefull()` is
called concurrently (e. g. "before") `run()`? Does it guarantee that the task
won't even start?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
