leventov commented on a change in pull request #8060: 6855 add Checkstyle for
constant name static final
URL: https://github.com/apache/incubator-druid/pull/8060#discussion_r312545707
##########
File path:
processing/src/test/java/org/apache/druid/query/topn/TopNQueryRunnerTest.java
##########
@@ -4321,27 +4321,18 @@ public void
testTopNWithExtractionFilterNoExistingValue()
}
DimFilter extractionFilter = new ExtractionDimFilter("null_column",
"NULL", lookupExtractionFn, null);
TopNQueryBuilder topNQueryBuilder = new TopNQueryBuilder()
- .dataSource(QueryRunnerTestHelper.dataSource)
- .granularity(QueryRunnerTestHelper.allGran)
+ .dataSource(QueryRunnerTestHelper.DATA_SOURCE)
+ .granularity(QueryRunnerTestHelper.ALL_GRAN)
.dimension("null_column")
- .metric(QueryRunnerTestHelper.indexMetric)
+ .metric(QueryRunnerTestHelper.INDEX_METRIC)
.threshold(4)
- .intervals(QueryRunnerTestHelper.fullOnIntervalSpec)
- .aggregators(
- Lists.newArrayList(
- Iterables.concat(
- commonAggregators,
- Lists.newArrayList(
- new FilteredAggregatorFactory(
- new DoubleMaxAggregatorFactory("maxIndex",
"index"),
- extractionFilter
- ),
- new DoubleMinAggregatorFactory("minIndex", "index")
- )
- )
- )
- )
- .postAggregators(QueryRunnerTestHelper.addRowsIndexConstant);
+ .intervals(QueryRunnerTestHelper.FULL_ON_INTERVAL_SPEC)
+ .aggregators(Lists.newArrayList(Iterables.concat(commonAggregators,
Lists.newArrayList(
Review comment:
Not proper formatting. Please reformat to something looking more like the
former code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
