leventov commented on a change in pull request #8060: 6855 add Checkstyle for
constant name static final
URL: https://github.com/apache/incubator-druid/pull/8060#discussion_r312551356
##########
File path: server/src/test/java/org/apache/druid/server/QueryResourceTest.java
##########
@@ -129,24 +129,24 @@ public void setup()
testRequestLogger = new TestRequestLogger();
queryResource = new QueryResource(
new QueryLifecycleFactory(
- warehouse,
- testSegmentWalker,
- new DefaultGenericQueryMetricsFactory(jsonMapper),
+ WAREHOUSE,
+ TEST_SEGMENT_WALKER,
+ new DefaultGenericQueryMetricsFactory(JSON_MAPPER),
new NoopServiceEmitter(),
testRequestLogger,
new AuthConfig(),
AuthTestUtils.TEST_AUTHORIZER_MAPPER
),
- jsonMapper,
- jsonMapper,
+ JSON_MAPPER,
+ JSON_MAPPER,
queryManager,
new AuthConfig(),
null,
- new DefaultGenericQueryMetricsFactory(jsonMapper)
+ new DefaultGenericQueryMetricsFactory(JSON_MAPPER)
);
}
- private static final String simpleTimeSeriesQuery = "{\n"
+ private static final String SIMPLE_TIME_SERIES_QUERY = "{\n"
Review comment:
Please call `SIMPLE_TIMESERIES_QUERY`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
