jihoonson commented on a change in pull request #8257: Add support for parallel native indexing with shuffle for perfect rollup URL: https://github.com/apache/incubator-druid/pull/8257#discussion_r313991124
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java ########## @@ -0,0 +1,467 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common.task.batch.parallel; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import com.google.common.util.concurrent.FutureCallback; +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.druid.client.indexing.IndexingServiceClient; +import org.apache.druid.data.input.FiniteFirehoseFactory; +import org.apache.druid.data.input.FirehoseFactory; +import org.apache.druid.data.input.InputSplit; +import org.apache.druid.indexer.TaskState; +import org.apache.druid.indexer.TaskStatusPlus; +import org.apache.druid.indexing.common.TaskToolbox; +import org.apache.druid.indexing.common.task.Task; +import org.apache.druid.indexing.common.task.batch.parallel.TaskMonitor.MonitorEntry; +import org.apache.druid.indexing.common.task.batch.parallel.TaskMonitor.SubTaskCompleteEvent; +import org.apache.druid.java.util.common.ISE; +import org.apache.druid.java.util.common.logger.Logger; + +import javax.annotation.Nullable; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.LinkedBlockingDeque; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; + +/** + * Base class for different implementations of {@link ParallelIndexTaskRunner}. + * It creates sub tasks, schedule them, and monitor their status. + */ +public abstract class ParallelIndexPhaseRunner<SubTaskType extends Task, SubTaskReportType extends SubTaskReport> + implements ParallelIndexTaskRunner<SubTaskType, SubTaskReportType> +{ + private static final Logger LOG = new Logger(ParallelIndexPhaseRunner.class); + + private final TaskToolbox toolbox; + private final String taskId; + private final String groupId; + private final ParallelIndexTuningConfig tuningConfig; + private final Map<String, Object> context; + private final int maxNumTasks; + private final IndexingServiceClient indexingServiceClient; + + private final BlockingQueue<SubTaskCompleteEvent<SubTaskType>> taskCompleteEvents = new LinkedBlockingDeque<>(); + + // subTaskId -> report + private final ConcurrentHashMap<String, SubTaskReportType> reportsMap = new ConcurrentHashMap<>(); + + private volatile boolean subTaskScheduleAndMonitorStopped; + private volatile TaskMonitor<SubTaskType> taskMonitor; + + private int nextSpecId = 0; + + ParallelIndexPhaseRunner( + TaskToolbox toolbox, + String taskId, + String groupId, + ParallelIndexTuningConfig tuningConfig, + Map<String, Object> context, + IndexingServiceClient indexingServiceClient + ) + { + this.toolbox = toolbox; + this.taskId = taskId; + this.groupId = groupId; + this.tuningConfig = tuningConfig; + this.context = context; + this.maxNumTasks = tuningConfig.getMaxNumSubTasks(); + this.indexingServiceClient = Preconditions.checkNotNull(indexingServiceClient, "indexingServiceClient"); + } + + /** + * Returns an iterator for {@link SubTaskSpec}s of this phase. + */ + abstract Iterator<SubTaskSpec<SubTaskType>> subTaskSpecIterator() throws IOException; + + /** + * Returns the total number of sub tasks required to execute this phase. + */ + abstract int getTotalNumSubTasks() throws IOException; + + @Override + public TaskState run() throws Exception + { + if (getTotalNumSubTasks() == 0) { + LOG.warn("There's no input split to process"); + return TaskState.SUCCESS; + } + + final Iterator<SubTaskSpec<SubTaskType>> subTaskSpecIterator = subTaskSpecIterator(); + final long taskStatusCheckingPeriod = tuningConfig.getTaskStatusCheckPeriodMs(); + + taskMonitor = new TaskMonitor<>( + Preconditions.checkNotNull(indexingServiceClient, "indexingServiceClient"), + tuningConfig.getMaxRetry(), + getTotalNumSubTasks() + ); + TaskState state = TaskState.RUNNING; + + taskMonitor.start(taskStatusCheckingPeriod); + + try { + LOG.info("Submitting initial tasks"); + // Submit initial tasks + while (isRunning() && subTaskSpecIterator.hasNext() && taskMonitor.getNumRunningTasks() < maxNumTasks) { + submitNewTask(taskMonitor, subTaskSpecIterator.next()); + } + + LOG.info("Waiting for subTasks to be completed"); + while (isRunning()) { + final SubTaskCompleteEvent<SubTaskType> taskCompleteEvent = taskCompleteEvents.poll( + taskStatusCheckingPeriod, + TimeUnit.MILLISECONDS + ); + + if (taskCompleteEvent != null) { + final TaskState completeState = taskCompleteEvent.getLastState(); + switch (completeState) { + case SUCCESS: + final TaskStatusPlus completeStatus = taskCompleteEvent.getLastStatus(); + if (completeStatus == null) { + throw new ISE("Last status of complete task is missing!"); + } + // Pushed segments of complete tasks are supposed to be already reported. + if (!reportsMap.containsKey(completeStatus.getId())) { + throw new ISE("Missing reports from task[%s]!", completeStatus.getId()); + } + + if (!subTaskSpecIterator.hasNext()) { + // We have no more subTasks to run + if (taskMonitor.getNumRunningTasks() == 0 && taskCompleteEvents.size() == 0) { + subTaskScheduleAndMonitorStopped = true; + if (taskMonitor.isSucceeded()) { + // Succeeded + state = TaskState.SUCCESS; + } else { + // Failed + final SinglePhaseParallelIndexingProgress monitorStatus = taskMonitor.getProgress(); + throw new ISE( + "Expected for [%d] tasks to succeed, but we got [%d] succeeded tasks and [%d] failed tasks", + monitorStatus.getExpectedSucceeded(), + monitorStatus.getSucceeded(), + monitorStatus.getFailed() + ); + } + } + } else if (taskMonitor.getNumRunningTasks() < maxNumTasks) { + // We have more subTasks to run + submitNewTask(taskMonitor, subTaskSpecIterator.next()); + } else { + // We have more subTasks to run, but don't have enough available task slots + // do nothing + } + break; + case FAILED: + // TaskMonitor already tried everything it can do for failed tasks. We failed. + state = TaskState.FAILED; + subTaskScheduleAndMonitorStopped = true; + final TaskStatusPlus lastStatus = taskCompleteEvent.getLastStatus(); + if (lastStatus != null) { + LOG.error("Failed because of the failed sub task[%s]", lastStatus.getId()); + } else { + final SinglePhaseSubTaskSpec spec = + (SinglePhaseSubTaskSpec) taskCompleteEvent.getSpec(); + LOG.error( + "Failed to run sub tasks for inputSplits[%s]", + getSplitsIfSplittable(spec.getIngestionSpec().getIOConfig().getFirehoseFactory()) + ); + } + break; + default: + throw new ISE("spec[%s] is in an invalid state[%s]", taskCompleteEvent.getSpec().getId(), completeState); + } + } + } + } + finally { + stopInternal(); + if (!state.isComplete()) { + state = TaskState.FAILED; + } + } + + return state; + } + + private boolean isRunning() + { + return !subTaskScheduleAndMonitorStopped && !Thread.currentThread().isInterrupted(); + } + + private void submitNewTask( + TaskMonitor<SubTaskType> taskMonitor, + SubTaskSpec<SubTaskType> spec + ) + { + LOG.info("Submit a new task for spec[%s] and inputSplit[%s]", spec.getId(), spec.getInputSplit()); + final ListenableFuture<SubTaskCompleteEvent<SubTaskType>> future = taskMonitor.submit(spec); + Futures.addCallback( + future, + new FutureCallback<SubTaskCompleteEvent<SubTaskType>>() + { + @Override + public void onSuccess(SubTaskCompleteEvent<SubTaskType> completeEvent) + { + // this callback is called if a task completed wheter it succeeded or not. Review comment: Thanks, fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
