jihoonson commented on a change in pull request #8257: Add support for parallel
native indexing with shuffle for perfect rollup
URL: https://github.com/apache/incubator-druid/pull/8257#discussion_r314482419
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##########
@@ -360,6 +369,23 @@ private LockGranularityDetermineResult
determineSegmentGranularity(List<DataSegm
}
}
+ static boolean isGuaranteedRollup(IndexIOConfig ioConfig, IndexTuningConfig
tuningConfig)
+ {
+ Preconditions.checkState(
+ !tuningConfig.isForceGuaranteedRollup() ||
!ioConfig.isAppendToExisting(),
Review comment:
Added some comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
