jihoonson commented on a change in pull request #8287: Cleanup appenderators 
and segment walkers in UnifiedIndexerAppenderatorsManager
URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r314495674
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppenderatorsManager.java
 ##########
 @@ -248,6 +289,50 @@ private AppenderatorConfig 
rewriteAppenderatorConfigMemoryLimits(AppenderatorCon
     return new MemoryParameterOverridingAppenderatorConfig(baseConfig, 
perWorkerLimit);
   }
 
+  private class DatasourceBundle
+  {
+    private final SinkQuerySegmentWalker walker;
+    private final Map<String, List<Appenderator>> taskAppenderatorMap;
+
+    public DatasourceBundle(
 
 Review comment:
   nit: all methods of this class can be `private`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to