jon-wei commented on a change in pull request #8287: Cleanup appenderators and
segment walkers in UnifiedIndexerAppenderatorsManager
URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r314546982
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppenderatorsManager.java
##########
@@ -183,22 +192,48 @@ public Appenderator createOfflineAppenderatorForTask(
IndexMerger indexMerger
)
{
- Appenderator appenderator = Appenderators.createOffline(
- schema,
- rewriteAppenderatorConfigMemoryLimits(config),
- metrics,
- dataSegmentPusher,
- objectMapper,
- indexIO,
- wrapIndexMerger(indexMerger)
- );
- return appenderator;
+ synchronized (this) {
Review comment:
I decided to leave it as is, since the shared portion is pretty small here
and I feel it's more readable without the additional indirection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
