himanshug edited a comment on issue #8328: [DISCUSS] Code generation for commonly implemented basic methods URL: https://github.com/apache/incubator-druid/issues/8328#issuecomment-522184350 IMHO, That is too magical. When I look at the source code, I want to know what is actually running ... e.g. if there is a stack trace from production server with line numbers for files inside druid source code etc, I would look at the source code that is checked in whereas actual code running is the rewrite from Lambok. That would add another variable to debugging equation for me to wonder is it possible that code generated by Lambok is buggy in some way. also, this is confusing for debuggers. When I am browsing through the source code and there is a line say... `xx.equals(yy)` and I tell the IDE to goto the place where `equals(..)` is defined, it would take me to wrong place most likely. (Same goes for other things generated e.g. getters/setters etc) OTOH It might be good to have something that can catch such issues and fail the build so that we can go fix it by writing/ide-generating that code manually.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
