lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r315564320
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java ########## @@ -69,6 +70,11 @@ public boolean canVectorize() public abstract Comparator getComparator(); + public Comparator getComparatorForFinalOrdering(OrderByColumnSpec columnSpec) Review comment: > AggregatorFactory provides a unified way to get comparator (`getComparator()`), but unlike other value types, strings can be compared in several ways. it seems that `getComparator(orderingType)` method should be more suitable for string first/last agg, but it is very confusing for other types of agg. As I mentioned above, that's why I add this new method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
