gianm commented on a change in pull request #8381: Fix inconsistent equals and
hashCode
URL: https://github.com/apache/incubator-druid/pull/8381#discussion_r317022529
##########
File path:
processing/src/main/java/org/apache/druid/query/ordering/StringComparators.java
##########
@@ -87,6 +87,12 @@ public boolean equals(Object o)
return true;
}
+ @Override
+ public int hashCode()
+ {
+ return super.hashCode();
Review comment:
I think this has the same problem as IdentityExtractionFn. It should return
a constant rather than `super.hashCode()`.
Please check the other usages of `super.hashCode()` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
