gianm commented on a change in pull request #8381: Fix inconsistent equals and
hashCode
URL: https://github.com/apache/incubator-druid/pull/8381#discussion_r317019832
##########
File path:
extensions-core/google-extensions/src/main/java/org/apache/druid/firehose/google/GoogleBlob.java
##########
@@ -72,5 +72,10 @@ public boolean equals(Object o)
return Objects.equals(bucket, that.bucket) &&
Objects.equals(path, that.path);
}
-}
+ @Override
+ public int hashCode()
+ {
+ return Objects.hash(getBucket(), getPath());
Review comment:
It doesn't matter too much, but might as well do `bucket` and `path` here to
match `equals`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
