leventov commented on a change in pull request #8391: Fix
ConcurrentModificationException in JDK11
URL: https://github.com/apache/incubator-druid/pull/8391#discussion_r317372468
##########
File path:
processing/src/main/java/org/apache/druid/segment/QueryableIndexColumnSelectorFactory.java
##########
@@ -76,21 +77,26 @@
@Override
public DimensionSelector makeDimensionSelector(DimensionSpec dimensionSpec)
{
- return dimensionSelectorCache.computeIfAbsent(
- dimensionSpec,
- spec -> {
- if (virtualColumns.exists(spec.getDimension())) {
- DimensionSelector dimensionSelector =
virtualColumns.makeDimensionSelector(dimensionSpec, index, offset);
- if (dimensionSelector == null) {
- return virtualColumns.makeDimensionSelector(dimensionSpec, this);
- } else {
- return dimensionSelector;
- }
- }
-
- return spec.decorate(makeDimensionSelectorUndecorated(spec));
+ Function<DimensionSpec, DimensionSelector> mappingFunction = spec -> {
+ if (virtualColumns.exists(spec.getDimension())) {
+ DimensionSelector dimensionSelector =
virtualColumns.makeDimensionSelector(dimensionSpec, index, offset);
+ if (dimensionSelector == null) {
+ return virtualColumns.makeDimensionSelector(dimensionSpec, this);
+ } else {
+ return dimensionSelector;
}
- );
+ }
+
+ return spec.decorate(makeDimensionSelectorUndecorated(spec));
+ };
+
+ DimensionSelector dimensionSelector =
dimensionSelectorCache.get(dimensionSpec);
Review comment:
There should be a comment explaining why it's not computeIfAbsent(), e. g.
referencing back to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
