leventov commented on a change in pull request #8391: Fix
ConcurrentModificationException in JDK11
URL: https://github.com/apache/incubator-druid/pull/8391#discussion_r317372492
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -414,11 +414,13 @@ public DimensionSelector
makeDimensionSelector(DimensionSpec dimensionSpec)
@Override
public ColumnValueSelector<?> makeColumnValueSelector(String columnName)
{
- final ColumnValueSelector existing = columnSelectorMap.get(columnName);
+ ColumnValueSelector existing = columnSelectorMap.get(columnName);
if (existing != null) {
return existing;
}
- return columnSelectorMap.computeIfAbsent(columnName,
delegate::makeColumnValueSelector);
+ ColumnValueSelector<?> columnValueSelector =
delegate.makeColumnValueSelector(columnName);
+ existing = columnSelectorMap.putIfAbsent(columnName,
columnValueSelector);
Review comment:
And here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
