leventov commented on a change in pull request #6943: InterruptedExceptions
should never be ignored in the code.
URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r317583515
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -305,6 +305,7 @@ public void run()
}
catch (InterruptedException e) {
// Just exit.
+ Thread.currentThread().interrupt();
Review comment:
Is it aligned with the semantics of "Just exit"? As a minimum, the comment
should go after, not before the `Thread.currentThread().interrupt();` statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
