leventov commented on a change in pull request #6943: InterruptedExceptions
should never be ignored in the code.
URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r317582949
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -761,6 +761,7 @@ public void tryInit()
catch (InterruptedException e) {
stateManager.recordThrowableEvent(e);
log.info("SeekableStreamSupervisor[%s] interrupted, exiting",
dataSource);
+ Thread.currentThread().interrupt();
Review comment:
By convention which you use in this PR,
`Thread.currentThread().interrupt();` (optionally wrapped in `if (e instanceof
InterruptedException)`) is the first statement in the catch block; please move
it here above, too. Also in other places in this file
`SeekableStreamSupervisor.java`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
