himanshug commented on a change in pull request #8458: Exit JVM on curator
unhandled errors
URL: https://github.com/apache/incubator-druid/pull/8458#discussion_r321002626
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorConfig.java
##########
@@ -26,16 +26,20 @@
import javax.validation.constraints.Min;
-/**
- */
public class CuratorConfig
{
- @JsonProperty("host")
+ static final String HOST = "host";
Review comment:
nit: if string literal is only used once then creating a static variable for
it is overkill IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
