himanshug commented on a change in pull request #8458: Exit JVM on curator
unhandled errors
URL: https://github.com/apache/incubator-druid/pull/8458#discussion_r321005922
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -225,4 +169,18 @@ public String getBackupConnectionString()
return ZooDefs.Ids.CREATOR_ALL_ACL;
}
}
+
+ private void shutdown(Lifecycle lifecycle)
+ {
+ //noinspection finally (not completing the 'finally' block normally is
intentional)
+ try {
+ lifecycle.stop();
+ }
+ catch (Throwable t) {
+ log.warn(t, "Exception when stopping druid lifecycle");
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
