jihoonson commented on a change in pull request #8564:
IndexerSQLMetadataStorageCoordinator.getTimelineForIntervalsWithHandle() don't
fetch abutting intervals; Simplify getUsedSegmentsForIntervals()
URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r327573821
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -125,14 +124,7 @@ public void start()
intervals
);
- return intervals
- .stream()
- .flatMap((Interval interval) ->
timeline.lookup(interval).stream())
- .flatMap(timelineObjectHolder -> {
- return
StreamSupport.stream(timelineObjectHolder.getObject().payloads().spliterator(),
false);
- })
- .distinct()
- .collect(Collectors.toList());
+ return new ArrayList<>(timeline.iterateAllObjects());
Review comment:
This can result in a different set of holders. `lookup()` can adjust the
first and last holders so that they are aligned with the given interval.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
