clintropolis commented on a change in pull request #8624: Use
targetRowsPerSegment for single-dim partitions
URL: https://github.com/apache/incubator-druid/pull/8624#discussion_r332917653
##########
File path:
indexing-hadoop/src/test/java/org/apache/druid/indexer/DeterminePartitionsJobTest.java
##########
@@ -51,6 +52,11 @@
@RunWith(Parameterized.class)
public class DeterminePartitionsJobTest
{
+ @Nullable
+ private static final Long NO_TARGET_ROWS_PER_SEGMENT = null;
Review comment:
nit: this seems _less_ clear to me than just using `null` inline, especially
since intellij displays parameter name for literal values by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
