clintropolis commented on a change in pull request #8624: Use
targetRowsPerSegment for single-dim partitions
URL: https://github.com/apache/incubator-druid/pull/8624#discussion_r332915814
##########
File path:
indexing-hadoop/src/main/java/org/apache/druid/indexer/DeterminePartitionsJob.java
##########
@@ -661,7 +661,7 @@ protected void innerReduce(Context context, SortableBytes
keyBytes, Iterable<Dim
}
// See if we need to cut a new partition ending immediately before
this dimension value
- if (currentDimPartition.rows > 0 && currentDimPartition.rows +
dvc.numRows >= config.getTargetPartitionSize()) {
+ if (currentDimPartition.rows > 0 && currentDimPartition.rows +
dvc.numRows > config.getTargetPartitionSize()) {
Review comment:
What is the justification for making this change in behavior that has
existed for over 6 years? I didn't see anything in the PR description to answer
the 'why', just mention that it has been changed. Could you please update the
PR description as well with whatever is the answer? It doesn't seem to make
much difference and I have no opinions either way, just curious what motivated
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
