jihoonson commented on a change in pull request #8570: Auto compaction based on parallel indexing URL: https://github.com/apache/incubator-druid/pull/8570#discussion_r332990163
########## File path: core/src/main/java/org/apache/druid/data/input/SegmentsSplitHintSpec.java ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.data.input; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; + +import javax.annotation.Nullable; +import java.util.Objects; + +/** + * {@link SplitHintSpec} for IngestSegmentFirehoseFactory. + */ +public class SegmentsSplitHintSpec implements SplitHintSpec +{ + public static final String TYPE = "segments"; + public static final long DEFAULT_MAX_INPUT_SEGMENT_BYTES_PER_TASK = 150 * 1024 * 1024; + + /** + * Maximum number of bytes of input segments to process in a single task. + * If a single segment is larger than this number, it will be processed by itself in a single task. + */ + private final long maxInputSegmentBytesPerTask; + + @JsonCreator + public SegmentsSplitHintSpec( + @JsonProperty("maxInputSegmentBytesPerTask") @Nullable Long maxInputSegmentBytesPerTask + ) + { + this.maxInputSegmentBytesPerTask = maxInputSegmentBytesPerTask == null Review comment: This parameter was added in https://github.com/apache/incubator-druid/pull/7048 and it doesn't count -1 as null. IMO, handling -1 as null is a legacy behavior and new parameters shouldn't do that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
