jihoonson commented on a change in pull request #8570: Auto compaction based on
parallel indexing
URL: https://github.com/apache/incubator-druid/pull/8570#discussion_r332990236
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexTuningConfig.java
##########
@@ -224,6 +238,39 @@ public int getTotalNumMergeTasks()
return totalNumMergeTasks;
}
+ @Override
+ public ParallelIndexTuningConfig withPartitionsSpec(PartitionsSpec
partitionsSpec)
+ {
+ return new ParallelIndexTuningConfig(
+ null,
+ null,
+ getMaxRowsInMemory(),
+ getMaxBytesInMemory(),
+ null,
+ null,
+ splitHintSpec,
+ partitionsSpec,
+ getIndexSpec(),
+ getIndexSpecForIntermediatePersists(),
+ getMaxPendingPersists(),
+ isForceGuaranteedRollup(),
+ isReportParseExceptions(),
+ getPushTimeout(),
+ getSegmentWriteOutMediumFactory(),
+ null,
+ maxNumConcurrentSubTasks,
+ maxRetry,
+ taskStatusCheckPeriodMs,
+ chatHandlerTimeout,
+ chatHandlerNumRetries,
+ maxNumSegmentsToMerge,
+ totalNumMergeTasks,
+ isLogParseExceptions(),
+ getMaxParseExceptions(),
+ getMaxSavedParseExceptions()
+ );
Review comment:
Changed to use getters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
