leventov commented on a change in pull request #8700: Add directExecutor for
cancel
URL: https://github.com/apache/incubator-druid/pull/8700#discussion_r336733394
##########
File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java
##########
@@ -496,7 +497,8 @@ public void onFailure(Throwable t)
}
}
}
- }
+ },
+ Execs.directExecutor()
Review comment:
`directExecutor()` and `sameThreadExecutor()` used by default are
essentially the same, so how does it fix the problem?
Independent of that, there should be a code comment explaining why explicit
executor is provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
