gianm commented on issue #8647: use the latest release of datasketches URL: https://github.com/apache/incubator-druid/pull/8647#issuecomment-544844113 > Druid is still compiling and targeting Java 1.8. > > Yet for PRs apparently, you are also requiring compatibility with JDK 9+. And this makes total sense, since the project currently only supports Java 8, but we are actively trying to move to supporting both Java 8 and Java 11 (see #5589). So the 'right direction' for any new patches is towards increasing Java 11 compatibility. > I guess the quickest way would be to modify [travis config](https://github.com/apache/incubator-druid/blob/master/.travis.yml#L226) for 'other modules test' and 'other modules test (SQL compatibility)' to skip datasketches extension for jdk11 only? Anyone else have any better ideas? I think since datasketches is known to not work properly on Java 11, @clintropolis's suggestion here is reasonable. We should definitely keep running the Java 11 tests on other modules. Actually, one weird thing is that currently, on the older datasketches version, the extension tests are _passing_! Based on @leerho's comment, they should be broken. So before implementing @clintropolis's suggestion to disable them on Java 11, it'd be good to figure out why they work today (we are probably missing some coverage of direct-buffer methods) and shore that up so the tests fail on the older datasketches version too. Then, commit that test, disabling the Java 11 tests in CI, upgrade to the latest datasketches, and raise a follow-up issue linked to #5589.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
