gianm commented on issue #8647: use the latest release of datasketches URL: https://github.com/apache/incubator-druid/pull/8647#issuecomment-558330039 > There is some problem with SQL tests. I am not familiar with this part of the code. It seems to me that someone set up very rigid tests asserting exact binary match of the resulting sketches: > org.apache.druid.query.aggregation.datasketches.theta.sql.ThetaSketchSqlAggregatorTest.testThetaSketchPostAggs(ThetaSketchSqlAggregatorTest.java:470) > Caused by: org.junit.ComparisonFailure: expected:<"AQMDAAA[a]zJOQxkPsNomrZQ=="> but was:<"AQMDAAA[6]zJOQxkPsNomrZQ=="> For this, I'd just update the tests to whatever the datasketches library is outputting now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
