zhenxiao commented on a change in pull request #8808: use copy-on-write list in
InMemoryAppender
URL: https://github.com/apache/incubator-druid/pull/8808#discussion_r342215463
##########
File path:
core/src/test/java/org/apache/druid/testing/junit/LoggerCaptureRule.java
##########
@@ -78,12 +77,13 @@ public void clearLogEvents()
{
static final String NAME = InMemoryAppender.class.getName();
- private final List<LogEvent> logEvents;
+ // need copy-on-write collection for thread safety of iteration and
modification concurrently outside of a critical section
Review comment:
how about:
logEvents has concurrent iteration and modification in
CuratorModuleTest::exitsJvmWhenMaxRetriesExceeded(), needs to be thread safe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
