ccaominh commented on a change in pull request #8748: Use earliest offset on
kafka newly discovered partitions
URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342276353
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
##########
@@ -156,9 +156,12 @@ protected void scheduleReporting(ScheduledExecutorService
reportingExec)
@Override
- protected int getTaskGroupIdForPartition(Integer partition)
+ protected int getTaskGroupIdForPartition(Integer partitionId)
{
- return partition % spec.getIoConfig().getTaskCount();
+ if (!partitionIds.contains(partitionId)) {
Review comment:
Can you add a comment explaining how this change prevents the original bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
