ccaominh commented on a change in pull request #8748: Use earliest offset on
kafka newly discovered partitions
URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r339806284
##########
File path:
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
##########
@@ -585,6 +585,113 @@ public void testLatestOffset() throws Exception
);
}
+ /**
+ * Test if always use earliest offset on newly discovered partitions
+ */
+ @Test
+ public void testLatestOffsetOnDiscovery() throws Exception
Review comment:
Ideally this test can be simplified to be a small extension of what's done
in `testLatest` (right now it seems to be doing more work than is necessary).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
