clintropolis commented on a change in pull request #8822: optimize numeric
column null value checking for low filter selectivity (more rows)
URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344352968
##########
File path:
processing/src/main/java/org/apache/druid/segment/vector/VectorSelectorUtils.java
##########
@@ -47,14 +47,33 @@
retVal = new boolean[offset.getMaxVectorSize()];
}
- // Probably not super efficient to call "get" so much, but, no worse than
the non-vectorized version.
if (offset.isContiguous()) {
+ final int startOffset = offset.getStartOffset();
+ nullIterator.advanceIfNeeded(startOffset);
+ if (!nullIterator.hasNext()) {
+ return null;
+ }
for (int i = 0; i < offset.getCurrentVectorSize(); i++) {
- retVal[i] = nullValueBitmap.get(i + offset.getStartOffset());
+ final int row = i + startOffset;
+ nullIterator.advanceIfNeeded(row);
+ if (!nullIterator.hasNext()) {
+ break;
+ }
+ retVal[i] = row == nullIterator.peekNext();
Review comment:
since the vectorized version doesn't save the `nullMark` like the other
version, doing `next` here could consume a value that is outside of the range
we are building the vector for, and we would lose it for the next vector that
has that value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
