clintropolis commented on a change in pull request #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r347806173
##########
File path:
core/src/main/java/org/apache/druid/data/input/AbstractInputSource.java
##########
@@ -53,12 +54,13 @@ protected InputSourceReader formattableReader(
InputRowSchema inputRowSchema,
InputFormat inputFormat,
@Nullable File temporaryDirectory
- )
+ ) throws IOException
{
throw new UnsupportedOperationException("Implement this method properly if
needsFormat() = true");
}
protected InputSourceReader fixedFormatReader(InputRowSchema inputRowSchema,
@Nullable File temporaryDirectory)
+ throws IOException
Review comment:
Ah yeah, nothing implements this method yet, I was preemptively adding it
because `InputSource.createSplits` is allows to throw an `IOException` and
readers will most likely be calling this method. I can remove for now, though I
suspect it will likely need to be added back later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
