jihoonson commented on a change in pull request #8810: Make supervisor API
similar to submit task API
URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r348191557
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpec.java
##########
@@ -42,8 +42,23 @@
{
private static final String TASK_TYPE = "kafka";
+ private static KafkaSupervisorTuningConfig getTuningConfig(
+ KafkaSupervisorIngestionSpec ingestionSchema,
+ KafkaSupervisorTuningConfig tuningConfig
Review comment:
Please annotate both `@Nullable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
