jihoonson commented on a change in pull request #8810: Make supervisor API similar to submit task API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r348197412
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpec.java ########## @@ -50,6 +50,7 @@ protected final SeekableStreamIndexTaskClientFactory indexTaskClientFactory; protected final ObjectMapper mapper; protected final RowIngestionMetersFactory rowIngestionMetersFactory; + private final SeekableStreamSupervisorIngestionSpec ingestionSchema; private final DataSchema dataSchema; Review comment: This class now has duplicate information between `ingestionSchema` and `dataSchema`, `ioConfig`, and `tuningConfig`. I suggest to remove `dataSchema`, `ioConfig`, and `tuningConfig` and keep only `ingestionSchema`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
