jon-wei commented on a change in pull request #8566: Upgrade Calcite to 1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r348862263
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -757,16 +761,16 @@ public void
testSelectStarFromSelectSingleColumnWithLimitDescending() throws Exc
newScanQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
.intervals(querySegmentSpec(Filtration.eternity()))
- .columns(ImmutableList.of("__time", "dim1"))
+ .columns(ImmutableList.of("dim1"))
.limit(2)
- .order(ScanQuery.Order.DESCENDING)
+ .order(ScanQuery.Order.NONE)
Review comment:
Added a comment, and an additional query within this test that uses the
outer context limit instead. One difference there is that the new query
includes __time within the results (otherwise the scan query rejects the query,
since it is ordering on __time)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
