jon-wei commented on a change in pull request #8566: Upgrade Calcite to 1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r348862696
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -2150,29 +2199,18 @@ public void testCountNullableColumn() throws Exception
@Test
public void testCountNullableExpression() throws Exception
{
- // Cannot vectorize due to expression filter.
- cannotVectorize();
-
testQuery(
"SELECT COUNT(CASE WHEN dim2 = 'abc' THEN 'yes' WHEN dim2 = 'def' THEN
'yes' END) FROM druid.foo",
ImmutableList.of(
Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
.intervals(querySegmentSpec(Filtration.eternity()))
.granularity(Granularities.ALL)
- .virtualColumns(
- expressionVirtualColumn(
- "v0",
- "case_searched((\"dim2\" == 'abc'),'yes',(\"dim2\"
== 'def'),'yes',"
- + DruidExpression.nullLiteral()
- + ")",
- ValueType.STRING
- )
- )
+ .virtualColumns()
Review comment:
Removed virtual columns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
